Skip to content

Sync 2 Inkeep OSS Changes#770

Merged
inkeep-oss-sync[bot] merged 2 commits into
mainfrom
copybara/sync
Jul 22, 2026
Merged

Sync 2 Inkeep OSS Changes#770
inkeep-oss-sync[bot] merged 2 commits into
mainfrom
copybara/sync

Conversation

@inkeep-oss-sync

Copy link
Copy Markdown
Contributor

Copybara-translated 2 Inkeep OSS changes. Rebase-merge this PR so the prepared commits land directly on public main.

Commits:

  • chore: rename mermaid-wysiwyg to visimer (#2843)
  • fix(open-knowledge): tear down the ok ui sibling when ok start exits via a signal (#2795)

anubra266 and others added 2 commits July 22, 2026 20:11
* chore: rename mermaid-wysiwyg to visimer

Directory public/mermaid-wysiwyg is now public/visimer. NPM packages
move from @inkeep/mermaid-wysiwyg-{core,dom,react,codemirror,monaco}
to scoped @visimer/{core,dom,react,codemirror,monaco}. Copybara mirror
target moves from inkeep/mermaid-wysiwyg to inkeep/visimer.

Also reverts the earlier site→mermaidraw rename inside the subtree:
apps/site stays apps/site (it's the demo site, not the library).

OK consumer stays on @inkeep/mermaid-wysiwyg-{core,dom}@0.1.0 for now;
follow-up once @visimer/* publishes to npm.

* fix(check-pre-push-mode.test): sort SUBTREES expected list after visimer rename

alphabetical order puts public/open-knowledge before public/visimer.

GitOrigin-RevId: 7ab9082a77d8333529e255280de2321e0e35fcf0
…its via a signal (#2795)

Fixes #692: `ok start` spawns a detached `ok ui` process
for the editor shell. On Ctrl+C (SIGINT/SIGTERM) the CLI destroyed the collab
server but never signalled the UI child, which lingered until its 12h safety
timer — holding its port so the next `ok start` bound a different one.

The signal path now runs the same guarded UI teardown as idle-shutdown, before
destroy releases server.lock. The SIGTERM → grace-poll → SIGKILL escalation is
factored out of `buildIdleShutdownHandler` into a shared `teardownUiSibling`, so
both call sites honor the SAME ownership guard: `spawnedUiPid` scopes the kill to
the sibling this process spawned, leaving a lock holder we did not spawn (a
desktop shell, another session) untouched. `BootedStartServer` now exposes
`spawnedUiPid` so the signal handler passes the owned pid through; the signal
path's teardown is wrapped so a failure there never bypasses destroy().

Reworks community PR #702 by @Adityakk9031, preserving the
`spawnedUiPid` ownership guard that #702 dropped and fixing its changeset
(correct package name, no BOM). Adds `teardownUiSibling` unit tests covering the
signal path's guard.

Co-authored-by: Aditya kumar singh <143548997+Adityakk9031@users.noreply.github.com>
GitOrigin-RevId: 67089dae1d813dbd3470369c7fd73142801a67c7
@inkeep-oss-sync
inkeep-oss-sync Bot merged commit 8a7779b into main Jul 22, 2026
@inkeep-oss-sync
inkeep-oss-sync Bot deleted the copybara/sync branch July 22, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants